Conversation
susnux
added
2. developing
susnux
force-pushed
the
chore/drop-jquery
branch
from
5550b87 to
d8189c4
Compare
susnux
force-pushed
the
chore/drop-jquery
branch
from
d8189c4 to
85965c0
Compare
6 tasks
susnux
force-pushed
the
chore/drop-jquery
branch
3 times, most recently
from
08f5601 to
89dc2be
Compare
susnux
added
the
pending documentation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
It is deprecated since 29.0.0. Instead use `openConflictPicker` from the `@nextcloud/upload` (Vue 2). Or from `@nextcloud/dialogs` (every other framework like Vue 3 etc). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Deprecated since 17.0.0, use the `@nextcloud/dialogs` package instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Instead use components from `@nextcloud/vue` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Instead use Vue components. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…tcloud/vue/components/NcDateTime` instead Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Use the DAV client from `@nextcloud/files/dav` instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
"jQuery is deprecated and will be removed with Nextcloud 19" Well... At least it is removed now 😉 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/drop-jquery
branch
from
89dc2be to
0b37d37
Compare
susnux
requested review from
Altahrim,
icewind1991,
nfebe,
salmart-dev,
skjnldsv and
szaimen
and removed request for
a team
susnux
added
3. to review
susnux
commented
Feb 17, 2026
|
|
||
| const fileInfo = new OC.Files.FileInfo(rawFileInfo) | ||
|
|
||
| // TODO remove when no more legacy backbone is used |
Contributor
Author
There was a problem hiding this comment.
FYI: Ideally we would migrate away to Node API. But files_sharing is very tangled with fileinfo objects.
So better to do it later in a follow up to not make this PR even worse (in terms of reviewability).
CarlSchwan
approved these changes
Feb 17, 2026
provokateurin
approved these changes
Feb 17, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
+538 -6,001 this is the kind of PR I like 😎
Contributor
|
🎉🎉🎉🎉🎉 |
Member
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Well no it was not. But it is now with Nextcloud 34.
This PR removed all jQuery UI related code:
OC.Dialogs.fileexists-> use@nextcloud/dialogsinsteadOC.Notifications-> use@nextcloud/dialogsinsteadOC.Apps-> use@nextcloud/vuecomponentsOC.*menu*-> use@nextcloud/vuecomponents.live-relative-timestamp-> useNcDateTimefrom@nextcloud/vuesnapper-> useNcAppNavigationfrom@nextcloud/vueOC.Files.ClientTODO
Requires this first:
OC.EventSourcefrom jQuery to native API #57644WhatsNew#57583NcAppNavigationin the settings app ( refactor(settings): useNcAppNavigationfor the settings navigation #57791 )Checklist
3. to review, feature component)stable32)